jaseg/gerbonara
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make sure we asterisk-terminate all G0x commands.

Browse source 
While this is common in the wild, not terminating them violates the
spec. It also breaks JLCPCB pretty badly. It seems their human review
process uses a Gerber viewer that like most can handle this, and won't
notice anything out of the ordinary, but then their photoplotter chokes
on this and literally stops plotting the file, discarding anything that
is after that line. This error is then apparently ignored and the
resulting broken boards shipped to the customer.
This commit is contained in:
jaseg 2022-08-19 16:50:57 +02:00
parent 2f5f7719c6
commit 07362c592f
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
gerbonara/rs274x.py
View file

@ -572,9 +572,9 @@ class GraphicsState:
def interpolation_mode_statement(self):
return {
InterpMode.LINEAR: 'G01',
InterpMode.CIRCULAR_CW: 'G02',
InterpMode.CIRCULAR_CCW: 'G03'}[self.interpolation_mode]
InterpMode.LINEAR: 'G01*',
InterpMode.CIRCULAR_CW: 'G02*',
InterpMode.CIRCULAR_CCW: 'G03*'}[self.interpolation_mode]
class GerberParser: